Check code for errors and warnings. #114
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warnings will still show in run output, as it is written differently. this is correct behavior. do not force error to display, in fact, turn them off.
Current coverage is 87.20%@@ master #114 diff @@
==========================================
Files 69 69
Lines 1574 1648 +74
Methods 280 291 +11
Messages 0 0
Branches 0 0
==========================================
+ Hits 1395 1437 +42
- Misses 179 211 +32
Partials 0 0
|
remove some array keys that worked in some environments, but not all. rewrite some test comparisons due to the changed formatting of some error messages. ran composer update, so have new lock file.
| ); | ||
| } | ||
|
|
||
| public function getActual() |
There was a problem hiding this comment.
can we add return types on these two methods
|
Great work , as you can see there is a fair bit of feedback, sorry for that! Also - we will have to introduce some unit tests here - the output comparison is a big part of the framework and I want to keep it solid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #4