Skip to content

Fix all those bytes #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix all those bytes #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ root = true

[*]
charset = utf-8
end_of_line = lf
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sixth key was missing.

indent_size = 4
indent_style = space
insert_final_newline = true
Expand Down
4 changes: 2 additions & 2 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
/.gitattributes export-ignore
/.editorconfig export-ignore
/.gitattributes export-ignore
/.gitignore export-ignore
/README.md export-ignore
/finder.php export-ignore
/generate.sh export-ignore
/release-latest-versions.sh export-ignore
/get_version.php export-ignore
/source export-ignore
/source/ export-ignore
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To show this is a directory.

4 changes: 1 addition & 3 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
.DS_Store
/vendor/
/composer.lock
/source/*
!/source/.gitkeep
/vendor/
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ core functions, classes and interfaces.
These stubs can help plugin and theme developers leverage static analysis tools
like [PHPStan](https://github.com/phpstan/phpstan).

The stubs are generated from source code manually placed in `source/facetwp`
The stubs are generated from source code manually placed in `source/facetwp`
using [php-stubs/generator](https://github.com/php-stubs/generator).

FacetWP's changelog can be found here [https://facetwp.com/help-center/changelog/](https://facetwp.com/help-center/changelog/).
Expand Down
4 changes: 2 additions & 2 deletions get_version.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ function plugin_basename() {}
function add_action() {}
function add_filter() {}

include_once('source/facetwp/index.php');
require_once __DIR__.'/source/facetwp/index.php';

echo FACETWP_VERSION;
echo FACETWP_VERSION;
2 changes: 2 additions & 0 deletions source/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
*
!/.gitignore
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.gitkeep is a from a fairy tale, it does not exist: https://git-scm.com/doc

Empty file removed source/.gitkeep
View file
Open in desktop
Empty file.