appendix 8.4 property hooks: confusing use of terms #4688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MAY This word, or the adjective "OPTIONAL", mean that an item is truly optional. RFC2119 in the property hooks example // A "virtual" property. It **may** not be set explicitly. could mean that the virtual property may OR may not be set explicitly. updated to // A "virtual" property. It **can** not be set explicitly. also added to the example to show the error that would be thrown if the property was set
belfie13
changed the title
kamil-tekiela
requested changes
Jun 5, 2025
| @@ -52,6 +52,8 @@ $p->firstName = 'peter'; | |||
| print $p->firstName; // Prints "Peter" | |||
| $p->lastName = 'Peterson'; | |||
| print $p->fullName; // Prints "Peter Peterson" | |||
|
|
|||
| $p->fullName = "Peter 'Pete' Peterson"; // Fatal error: Property is read-only | |||
There was a problem hiding this comment.
Suggested change
| $p->fullName = "Peter 'Pete' Peterson"; // Fatal error: Property is read-only | |
| $p->fullName = "Peter 'Pete' Peterson"; // Throws Error: "Property Person::$fullName is read-only" |
| @@ -23,7 +23,7 @@ | |||
| <?php | |||
| class Person | |||
| { | |||
| // A "virtual" property. It may not be set explicitly. | |||
| // A "virtual" property. It can not be set explicitly. | |||
There was a problem hiding this comment.
Suggested change
| // A "virtual" property. It can not be set explicitly. | |
| // A "virtual" property. It cannot be set explicitly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAY This word, or the adjective "OPTIONAL", mean that an item is truly optional. RFC2119
in the property hooks example
// A "virtual" property. It **may** not be set explicitly.could mean that the virtual property may OR may not be set explicitly.
updated to
// A "virtual" property. It **can** not be set explicitly.also added to the example to show the error that would be thrown if the property was set