-
Notifications
You must be signed in to change notification settings - Fork 824
Enable runnable (WASM) examples for datetime #4887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
<programlisting role="php"> | ||
<![CDATA[ | ||
<?php | ||
Deprecated: Calling DatePeriod::__construct(string $isostr, int $options = 0) is deprecated, use DatePeriod::createFromISO8601String() instead in script on line 11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this right? Did you accidently put this in the wrong place?
</programlisting> | ||
&example.outputs; | ||
<screen> | ||
<![CDATA[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<![CDATA[ | |
<![CDATA[ |
</programlisting> | ||
&example.outputs; | ||
<screen> | ||
<![CDATA[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<![CDATA[ | |
<![CDATA[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you split it up? Both examples should produce identical output and there should only be one output section.
Related to #4799
Including fixing markup to make sure output replacement works correctly.
Additional changes I made:
?>
(PER coding style, also I see new users using this too often and suspect the manual is partly to blame)The first example on strftime() isn't working. I suspect this is due to the WASM environment not having locales or something. Since the function is deprecated I decided not to both investigating too deeply and just marked it as not runnable.