Add deprecation/changelog for switch statement semicolons. #4895
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find it appropriate. This what it's for. See also: https://www.php.net/manual/en/info.configuration.php#ini.assert.active where the snippet is used for various INIs. |
|
I'm not sure what to do with the changelog here. It seems like we're going to need to redo the whole file to allow it to use a section tag? That seems... scope creepy, but also a blocker. Please advise, someone who knows this better than I do. |
I'm not sure we need the changelog. I don't think this was previously done for similar pages / it was only done for functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if it makes sense to use the "deprecated" entities here, since it's just a tiny part of the syntax that's deprecated, not the whole thing. The "feature" warning seems like it would be overkill. So I just adjusted the text and added a changelog.