edit description for filename parameter in finfo-file.xml (php#4803) #4913
Conversation
| <listitem> | ||
| <para> | ||
| Name of a file to be checked. | ||
| Name of a local file to be checked. Remote URLs are not supported. |
There was a problem hiding this comment.
Should it not say URIs? Also, what is the source of this information?
There was a problem hiding this comment.
To be completely honest, I'm not a PHP developer — I just came across this issue during Hacktoberfest.
From my point of view, there are three indicators that confirm this is correct:
-
The open issue states it very clearly: (Improve finfo_file documentation to state that the file must be local #4803)
“Suggested improvement: Clearly mention in the documentation that $filepath must be a local file and remote URLs are not accepted.” -
I asked ChatGPT about it, and it confirmed the same.
-
A PHP colleague double-checked it and tested the function with an external URL — it didn’t work. However, using a local file worked correctly.
But if you don’t want to have it written that way in the documentation, feel free to just decline the PR.
Of course, I don’t want anything “incorrect” to be added either.
If you’d like, you can double-check it yourselves and adjust the wording however you think fits best 🙂
There was a problem hiding this comment.
I don't know why it doesn't work with remote files, because it does use streams. Perhaps someone else more knowledge can review this PR.
2 participants
No description provided.