Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override deprecationRulesInstalled config to true #77

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Override deprecationRulesInstalled config to true #77

merged 1 commit into from
Dec 7, 2022
+2 −1

Conversation

villfa
Copy link
Contributor

@villfa villfa commented Dec 7, 2022

2nd step of the plan described here phpstan/phpstan-phpunit#150 (comment)

@villfa villfa marked this pull request as ready for review December 7, 2022 16:42
@villfa villfa changed the title Override deprecationRulesInstalled config to true Override deprecationRulesInstalled config to true Dec 7, 2022
@ondrejmirtes ondrejmirtes merged commit f6e02de into phpstan:1.1.x Dec 7, 2022
@ondrejmirtes
Copy link
Member

Thank you :)

@villfa villfa deleted the feat/installed-config branch December 7, 2022 16:49
@ondrejmirtes
Copy link
Member

BTW you've put it into a wrong file, it has no effect. It has to be in rules.neon :)

@villfa
Copy link
Contributor Author

villfa commented Dec 13, 2022

Oh, sorry about that -_-'

@villfa villfa mentioned this pull request Dec 13, 2022
Merged
@villfa
Copy link
Contributor Author

villfa commented Dec 13, 2022

Here the fix for that: #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@villfa @ondrejmirtes