Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecationRulesInstalled not being set to true automatically #79

Closed
wants to merge 2 commits into from

Conversation

ben-challis
Copy link

@ben-challis ben-challis commented Dec 13, 2022

I tried to implement this for static PHPUnit dataProvider's from phpstan/phpstan-phpunit and couldn't get it to work without myself overriding the parameter value in our own phpstan.neon configuration.

I've dropped it from phpstan.neon as well as I believe that's redundant now.

@ben-challis ben-challis changed the title Override deprecationRulesInstalled in rules.neon Fix deprecationRulesInstalled not being set to true automatically Dec 13, 2022
@ondrejmirtes
Copy link
Member

Although you were faster, I like parameters at the top :) Sorry. I'm gonna merge #80.

@ben-challis ben-challis deleted the patch-1 branch December 13, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants