Simplify by replacing chained $var === const with in_array()
#4098
+295
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonuexe
changed the title
$var === const with in_array()Refactor/or idetical chain to in array()$var === const with in_array()
ondrejmirtes
requested changes
Jul 17, 2025
|
|
||
| public function __construct( | ||
| #[AutowiredParameter] | ||
| private PhpPrinter $printer, |
There was a problem hiding this comment.
Do not make this a DI service. Ask for ExprPrinter instead which is already a DI service.
There was a problem hiding this comment.
Thanks, I replaced it with ExprPrinter.
zonuexe
force-pushed
the
refactor/or-idetical-chain-to-in_array
branch
from
6044c89 to
1b0b7d4
Compare
|
I see, the error that occurred after rebasing seems to be independent of the changes in this PR. |
|
This pull request has been marked as ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same change as the previous one at #2618, but it will be automatically refactored by rules 🤖.
Currently,
return $var === 'foo' || $var === 'bar';and$isFooOrBar = $var === 'foo' || $var === 'bar';are not covered. It also does not support formulas replaced by De Morgan's laws.