added phuse css 2025 feedback #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine and supporting documentation for reproducing the R environment.
…t in ADRG documentation
… sections in ADRG documentation
There was a problem hiding this comment.
Pull Request Overview
Adds PHUSE CSS 2025 feedback and presentation support by integrating a suite of reveal.js plugins and configurations.
- Introduces zoom, search, menu, quarto-support, line-highlight, pdf-export, and notes plugins with their ESM and non-ESM builds
- Provides corresponding CSS styles and YAML configuration for each plugin
- Sets up speaker notes view and PDF export functionality for the presentations
Reviewed Changes
Copilot reviewed 49 out of 91 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/site_libs/revealjs/plugin/zoom/zoom.js | Adds CommonJS zoom plugin |
| docs/site_libs/revealjs/plugin/zoom/zoom.esm.js | Adds ESM zoom plugin |
| docs/site_libs/revealjs/plugin/zoom/plugin.js | Adds high-level zoom plugin integration |
| docs/site_libs/revealjs/plugin/search/search.js | Adds CommonJS search plugin |
| docs/site_libs/revealjs/plugin/search/search.esm.js | Adds ESM search plugin |
| docs/site_libs/revealjs/plugin/search/plugin.js | Adds high-level search plugin integration |
| docs/site_libs/revealjs/plugin/reveal-menu/quarto-menu.js | Adds Quarto-specific menu tools |
| docs/site_libs/revealjs/plugin/reveal-menu/quarto-menu.css | Styles for Quarto menu items |
| docs/site_libs/revealjs/plugin/reveal-menu/plugin.yml | Menu plugin configuration |
| docs/site_libs/revealjs/plugin/reveal-menu/menu.js | Adds core reveal-menu logic |
| docs/site_libs/revealjs/plugin/reveal-menu/menu.css | Styles for reveal-menu |
| docs/site_libs/revealjs/plugin/quarto-support/support.js | Adds Quarto support utilities |
| docs/site_libs/revealjs/plugin/quarto-support/plugin.yml | Quarto-support plugin configuration |
| docs/site_libs/revealjs/plugin/quarto-support/footer.css | Footer styling for Quarto support |
| docs/site_libs/revealjs/plugin/quarto-line-highlight/plugin.yml | Line-highlight plugin configuration |
| docs/site_libs/revealjs/plugin/quarto-line-highlight/line-highlight.js | Adds Quarto line-highlighting logic |
| docs/site_libs/revealjs/plugin/quarto-line-highlight/line-highlight.css | Styles for line highlighting |
| docs/site_libs/revealjs/plugin/pdf-export/plugin.yml | PDF-export plugin configuration |
| docs/site_libs/revealjs/plugin/pdf-export/pdfexport.js | Adds PDF export functionality |
| docs/site_libs/revealjs/plugin/notes/speaker-view.html | Speaker-view HTML template |
| docs/site_libs/revealjs/plugin/notes/plugin.js | Adds notes synchronization plugin |
| } | ||
| } | ||
|
|
||
| // implement controlsAudo |
There was a problem hiding this comment.
Typo in comment: 'controlsAudo' should be 'controlsAuto'.
Suggested change
| // implement controlsAudo | |
| // implement controlsAuto |
Copilot uses AI. Check for mistakes.
|
|
||
| function splitLineNumbers(lineNumbersAttr) { | ||
| // remove space | ||
| lineNumbersAttr = lineNumbersAttr.replace("/s/g", ""); |
There was a problem hiding this comment.
The string '/s/g' won’t match whitespace; use a RegExp literal /\s/g instead of the quoted string.
Suggested change
| lineNumbersAttr = lineNumbersAttr.replace("/s/g", ""); | |
| lineNumbersAttr = lineNumbersAttr.replace(/\s/g, ""); |
Copilot uses AI. Check for mistakes.
|
Hi, @Lovemore-Gakava . Thanks for allowing me to review this feedback. A couple of requests :
or maybe I'm missing something in my local render that is not allowing me to see the link as easily? |
Merge branch '14-phusefda-css-2025' of https://github.com/phuse-org/OSDocuMeta into 14-phusefda-css-2025 # Conflicts: # docs/dev/custom.css
Merge remote-tracking branch 'origin/main' into 14-phusefda-css-2025 # Conflicts: # docs/index.html # docs/minutes.html # docs/search.json
Co-authored-by: Copilot <[email protected]>
@laxamanaj thanks for the comments. I have merged the current main to the PR branch. I have also added the presentation to the home page under Presentations header. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added phuse css 2025 feedback and also add phuse css 2025 presentation.