Skip to content

Add SpireStreet class #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Mar 27, 2024
Merged

Add SpireStreet class #148

merged 38 commits into from
Mar 27, 2024

Conversation

Grufoony
Copy link
Collaborator

@Grufoony Grufoony commented Mar 16, 2024 •
edited
Loading

Partially implements #110

TODO:

  • Rename isSpire attribute and methods from Street class
  • Check Dynamics compatibility

@Grufoony Grufoony added the check required More details required label Mar 16, 2024
@Grufoony Grufoony self-assigned this Mar 16, 2024
sbaldu and others added 27 commits March 16, 2024 18:11
@sbaldu
Remove aliases for smart pointers
51991e3
@sbaldu
Update nomenclature
ff33807
@sbaldu
Add virtual destructor for Node
823e762
@sbaldu
Add isTrafficLight method for nodes
d656f6e
@sbaldu
Substitute shared with unique and remove useless pointers
ea91847
@sbaldu
Update tests
a053228
@sbaldu
Fix typo and specify special constructors for Graph
c8aa014
@sbaldu
Write copy constructor/assign for Graph
8697ca8
@Grufoony @sbaldu
Fix non-const methods in SparseMatrix class
0544298
@sbaldu
Update profiling main
542fce9
@sbaldu
Change -O3 to '-Os' for profiling
7245ebe
@sbaldu
revrite type traits for unique_ptr
b762d87
@sbaldu
Fix makeTrafficLight
de4238c
@sbaldu
Update type traits tests
e21a351
@Grufoony
Add TL constructor from Node to fix makeTrafficLight
0557d56
@Grufoony
Fix bug in updatePaths
a0c39a2
@Grufoony
Update
eda2565
@Grufoony
Code refactor
74e4f78
@Grufoony
New test. Should fix #151
cebdd9a
@Grufoony
I hate nullptr
5f3b4d5
@Grufoony
Changed auto& to const auto&
b9241cd
@Grufoony
Merge branch 'rework_shared_to_unique' into feature_add_SpireStreet
40529a5
@Grufoony
Reworked old isSpire
6177c67
@Grufoony
Update version
b7e3259
@Grufoony
Add makeSpireStreet method to graph
939c11a
@Grufoony
Update version
ca487e7
@Grufoony
Rework graph getter
a2d16ea
@Grufoony Grufoony marked this pull request as ready for review March 18, 2024 21:38
@Grufoony
Copy link
Collaborator Author

@sbaldu please check the change of the graph getter in dynamics

@Grufoony Grufoony requested a review from sbaldu March 18, 2024 21:40
@Grufoony Grufoony added test Regarding the tests of the code addition dynamics Regarding the dynamics of the system priority::high High priority stuff labels Mar 18, 2024
@sbaldu sbaldu merged commit 2141cb2 into main Mar 27, 2024
20 of 22 checks passed
@Grufoony Grufoony deleted the feature_add_SpireStreet branch April 8, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbaldu sbaldu sbaldu approved these changes

Assignees

@Grufoony Grufoony

Labels
check required More details required dynamics Regarding the dynamics of the system priority::high High priority stuff test Regarding the tests of the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Grufoony @sbaldu