Better user interface to edit reverse DNS servers (dns.revServers)#2943
Better user interface to edit reverse DNS servers (dns.revServers)#2943rdwebdesign wants to merge 15 commits intodevelopmentfrom
dns.revServers)#2943Conversation
18799fe to
64efa24
Compare
DL6ER
left a comment
There was a problem hiding this comment.
I did test your PR and it looks really great overall. However, I see you moved this PR into draft mode again and I hope the reason is: because you are adding editing :-)
The first thing I noticed was my currently defined revServer cannot be disabled. The ideal solution would be having <input> boxes in the table and allow full-blown editing (rendering the new multi-line raw value for revServers fromt he fields on save).
This is expected... In the current state, this PR can only add and delete entries. I didn't create functions to edit fields (this checkbox is just a nice way to display true/false values).
This is in my todo list. |
043ce9d to
da84675
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. |
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
…ield Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
|
@rdwebdesign |
|
I completely forgot about it. I will take a look again when I find some time, but this is not necessary to v6 release. |
|
I agree, it'd also a nice v6.1 thing |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Existing merge conflicts have not been addressed. This PR is considered abandoned. |
|
This will be addressed in the future, after v6 release. I'm reopening the PR. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Existing merge conflicts have not been addressed. This PR is considered abandoned. |
|
Existing merge conflicts have not been addressed. This PR is considered abandoned. |
|
We agreed on it being a v6.1 project |
|
@rdwebdesign what is the satus of this PR please? |
|
A lot of users would love to see progress on this |
|
What is the status of this? |

What does this PR aim to accomplish?
Replace the current single
<textarea>with a table.Each reverse server will be in a separate row and each field will be in a separate table cell.
A small legend will improve usability (maybe we will need to change the help text).
NOTE:
Depends on #2885(already merged)How does this PR accomplish the above?
Using datatables plugin and a few functions to deal with dns.revServers entries.
By submitting this pull request, I confirm the following:
git rebase)