Add autocomplete improvements#587
Open
markusand wants to merge 2 commits intopicturepan2:masterfrom
markusand:master
Open
Add autocomplete improvements#587markusand wants to merge 2 commits intopicturepan2:masterfrom markusand:master
markusand wants to merge 2 commits intopicturepan2:masterfrom
markusand:master
Conversation
added 2 commits
April 23, 2019 13:30
I don't understand the functionality of the .on-focus class. While the docs say 'You may add the is-focused class to form-autocomplete-input to make it appear as focus state' it actually only manages shadow and border color. I added an .autocomplete-dropdown class that hides the menu and shows it on hover or on focus. There is also a translate reset to prevent .menu hiding when mouse hovers the gap between .form-autocmplete-input and .menu
Chips keep their size and don't grow when autocomplete is set to oneline
houndci-bot
reviewed
Apr 23, 2019
|
|
||
| &:hover > .menu, | ||
| &:focus-within > .menu { display: block; } | ||
|
|
| display: none; | ||
| transform: translateY(0); | ||
| } | ||
|
|
| flex: 0 0 auto; | ||
| } | ||
| } | ||
|
|
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two slight improvements to autocomplete: