Update Gencert with TLS1.3 compatibility#169
Open
adamoutler wants to merge 3 commits intopikvm:masterfrom
Open
Update Gencert with TLS1.3 compatibility#169adamoutler wants to merge 3 commits intopikvm:masterfrom
adamoutler wants to merge 3 commits intopikvm:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is required to provide a Subject Alternate Name for the certificate rather than no SANs at all. The default "localhost" is retained. New certified IPs/hostnames include
This change allows a user to trust the PiKVM cert as a Root cert by default. After generating a cert with the
scripts/kvmd-gencert, any acquired IPv4 and IPv6 addresses along withpikvm-${ProcessorSerialNumber}are registered as subject alternate names for the cert. This allows the certificate to be used as a Trusted Root Certificate.In Windows/Chrome
Possible Future improvements:
pikvm-${ProcessorSerialNumber}the official cert name instead of localhost. This will help to identify the certificates in the keystore.