Open
Conversation
Member
|
Hello. Do you really need entire rust library for this? This is not packed in distro, and we have no mechanism for optional deps. As I understand, tapo api is just a REST, maybe you can change the plugin to make http calls directly and avoid this dep? |
Author
|
Hey @mdevaev - very valid point, I did think about that but it initially seemed a bit complex. Let me go back to the drawing board and work out if there's another option 👍 |
Member
|
Hello! How it's going? Is it still relevant for you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings in a tapo smart plug integration for GPIO. This supports devices as follows: https://www.tapo.com/en/product/smart-plug/
The only thing that this requires is the
tapopython module, which I'm not sure how to include, or whether or not this project will be happy to have that included? Is there a way to specify this as an optional dependency? I've just been testing by running:I looked into how this was done inside the python module, and its relatively complex so not just as simple as bringing in an HTTP call.
Example
/etc/kvmd/override.yaml:Please provide any and all feedback!