Fix deletion of inherited models#18
Open
ron8mcr wants to merge 2 commits into
Open
Conversation
As referenced in pinax#13, not all related objects should be deleted. But I think that ``ForeignKey`` should resolve it by itself, using ``on_delete`` param. The same applies to ``OneToOneField``. But there is another case with inherited models. Consider following case: ``` class BaseModel(UndeleteBase): name = models.CharField(default='Empty name', max_length=256) class InhertedModel(BaseModel): description = models.TextField(default='Some description') ``` In this case, when the instance of ``InhertedModel`` would be deleted, related objects will contain linked the instance of ``BaseModel`` and it's ``delete`` method will be called. Which collect instance of ``InhertedModel`` in related objects and call it's ``delete`` method. So we will have endless recursion. This commit fixes it
ron8mcr
changed the title
Previous fix worked just for inherited
models, but fails with models that have
``ForeignKey('self')``. Now it fixed
Author
|
Travis checks failed with Django's master branch and seem like issue there, not in commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As referenced in #13, not all related objects should be deleted.
But I think that
ForeignKeyshould resolve it by itself, usingon_deleteparam. The same applies toOneToOneField.But there is another case with inherited models.
Consider following case:
In this case, when the instance of
InhertedModelwould be deleted, related objects will contain linked the instance ofBaseModeland it'sdeletemethod will be called. Which collect instance ofInhertedModelin related objects and call it'sdeletemethod.So we will have endless recursion.
This commit fixes it