Skip to content

Fix: GRPCIndex.query future result type #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yorickvP
Copy link
Contributor

This was missing a parse_query_response call, causing the result to be the raw Message.

Problem

GRPCIndex.query was returning a raw Message when using async_req. This change fixes that.

Solution

Set a result_transformer on the future to parse it.

Type of Change

This is somewhat breaking because anyone affected was likely working around it.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Unclear, the current strategy for testing query doesn't actually generate a response.

This was missing a parse_query_response call, causing the result
to be the raw Message.
@jhamon
Copy link
Collaborator

jhamon commented May 23, 2025

I see what you're saying. I'll try to add some tests for this codepath.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants