-
Notifications
You must be signed in to change notification settings - Fork 702
cloud: update the TOC of "Migrate or Import Data" for Starter and Essential #21585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @qiancai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the Table of Contents (TOC) for the "Migrate or Import Data" section within the TiDB Cloud documentation, specifically for the Starter and Essential plans. The changes aim to improve the clarity and relevance of migration guides by replacing outdated or less common migration scenarios with more pertinent ones, such as migrating from self-managed TiDB and using AWS DMS for MySQL-compatible databases. Additionally, a new guide for connecting AWS DMS to TiDB Cloud clusters has been added to enhance the import process documentation.
Highlights
- Updated Migration Paths: The documentation for TiDB Cloud Essential and Starter plans has been updated to reflect more relevant and current migration paths.
- Refined Migration Guides: Specific links for migrating from self-managed TiDB and general MySQL-compatible databases using AWS DMS have been introduced.
- New AWS DMS Connection Guide: A new entry has been added to the Essential plan's TOC to guide users on connecting AWS DMS to TiDB Cloud clusters.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the "Migrate or Import Data" section in the Table of Contents for both Starter and Essential plans. The changes replace a general guide on migrating MySQL shards with more specific guides for migrating from self-managed TiDB and other MySQL-compatible databases. A reference to connecting with AWS DMS is also added.
My review identifies one point of inconsistency: the guide for migrating from Oracle via AWS DMS has been removed from the Essential plan's TOC but remains in the Starter plan's TOC. I've suggested adding it back to the Essential plan's TOC for consistency.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@@ -227,6 +228,7 @@ | |||
- [Naming Conventions for Data Import](/tidb-cloud/naming-conventions-for-data-import.md) | |||
- [CSV Configurations for Importing Data](/tidb-cloud/csv-config-for-import-data.md) | |||
- [Troubleshoot Access Denied Errors during Data Import from Amazon S3](/tidb-cloud/troubleshoot-import-access-denied-error.md) | |||
- [Connect AWS DMS to TiDB Cloud clusters](/tidb-cloud/tidb-cloud-connect-aws-dms.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we move the "Connect AWS DMS to TiDB Cloud clusters" link into the "Migrate Data into TiDB Cloud" section. AWS DMS serves as an alternative to TiDB's Data Migration (DM) tool, so it would be more intuitive for users to find it grouped with the other migration methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alastori Currently, "Connect AWS DMS to TiDB Cloud clusters" is in the "Reference" section because it is referenced as a detailed connection step in other docs.
Users might read Migrate from Amazon RDS for Oracle to TiDB Cloud Using AWS DMS first (because their primary purpose is migrating data) and then follow the following link to go to the Connect AWS DMS to TiDB Cloud clusters doc.

…or starter and essential
…into update-starter-migrate-toc
@@ -237,7 +237,6 @@ | |||
- [Migrate and Merge MySQL Shards of Large Datasets](/tidb-cloud/migrate-sql-shards.md) | |||
- [Migrate from TiDB Self-Managed to TiDB Cloud](/tidb-cloud/migrate-from-op-tidb.md) | |||
- [Migrate from MySQL-Compatible Databases Using AWS DMS](/tidb-cloud/migrate-from-mysql-using-aws-dms.md) | |||
- [Migrate from Amazon RDS for Oracle Using AWS DMS](/tidb-cloud/migrate-from-oracle-using-aws-dms.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reason: This first paragraph in this doc mentions that "This document describes a step-by-step example of how to migrate data from Amazon RDS for Oracle to TiDB Cloud Starter using AWS Database Migration Service (AWS DMS)."
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zhangyangyu: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?