fix: set tidb tunning variables only when connected to valid tidb #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@zanmato1984 |
zanmato1984
reviewed
Feb 24, 2025
| // isValidTuningVersion checks if the version is a valid TiDB version for query tuning params @queryTuningVars | ||
| // @version the output serverVersion of tidb using @getServerVersion | ||
| // INFO: Should be optimized if some vars are changed in the future. | ||
| func isValidTuningVersion(version string) bool { |
There was a problem hiding this comment.
I think we should split this function into two: one extracting a version struct of {major int, minor int, patch string}, the other asserting if a given system variable is supported by the given version struct (func isSysVarSupported(version versionInfo, sysVar string)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #187
According to System Variables | TiDB Docs, set TiDB QueryTuningVars only when connected to TiDB(>=7.1.0).
It's still a rough comparison to quickly fix the compatibility issue.