Skip to content

parser: support MySQL 8.0.19+ INSERT row alias syntax #67920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paultyng wants to merge 2 commits into
base: master
Choose a base branch
from
+7,887 −7,754
Open

parser: support MySQL 8.0.19+ INSERT row alias syntax #67920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7af8a6
feat(parser): support MySQL 8.0.19+ INSERT row alias syntax
paultyng Apr 20, 2026
7c1f4e9
fix(parser): reject row alias on REPLACE statements
paultyng Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions pkg/parser/ast/dml.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2401,6 +2401,12 @@ type InsertStmt struct {
// TableHints represents the table level Optimizer Hint for join type.
TableHints []*TableOptimizerHint
PartitionNames []CIStr
// RowAlias is the optional row alias for VALUES/SET clause (MySQL 8.0.19+).
// e.g. INSERT INTO t VALUES (1,2) AS new ON DUPLICATE KEY UPDATE b = new.b
RowAlias CIStr
// ColumnAliases is the optional column alias list for the row alias.
// e.g. INSERT INTO t VALUES (1,2) AS new(m, n) ON DUPLICATE KEY UPDATE b = m
ColumnAliases []CIStr
}

// Restore implements Node interface.
Expand Down Expand Up @@ -2515,6 +2521,20 @@ func (n *InsertStmt) Restore(ctx *format.RestoreCtx) error {
return errors.Errorf("Incorrect type for InsertStmt.Select: %T", v)
}
}
if asName := n.RowAlias.String(); asName != "" {
ctx.WriteKeyWord(" AS ")
ctx.WriteName(asName)
if len(n.ColumnAliases) > 0 {
ctx.WritePlain("(")
for i, col := range n.ColumnAliases {
if i > 0 {
ctx.WritePlain(", ")
}
ctx.WriteName(col.String())
}
ctx.WritePlain(")")
}
}
if n.OnDuplicate != nil {
ctx.WriteKeyWord(" ON DUPLICATE KEY UPDATE ")
for i, v := range n.OnDuplicate {
Expand Down
Loading
Loading