Skip to content

Revert core UI palette layering tweaks#1952

Closed
juliusmarminge wants to merge 2 commits intomainfrom
t3code/revert-core-ui-palette
Closed

Revert core UI palette layering tweaks#1952
juliusmarminge wants to merge 2 commits intomainfrom
t3code/revert-core-ui-palette

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Apr 12, 2026

Summary

  • Reverts the command palette backdrop and input wrapper layering adjustments.
  • Restores the previous command dialog backdrop treatment while keeping the palette structure intact.
  • Lowers toast stacking order back to the prior z-index behavior.

Testing

  • Not run

Note

Low Risk
Low risk UI-only changes that adjust dialog backdrop styling and slightly refactor command palette input layout; main risk is minor visual/regression in overlay appearance.

Overview
Updates the command palette dialog overlay styling by changing the default CommandDialogBackdrop to a darker, blurred backdrop and adding a backdropClassName override on CommandDialogPopup (used by CommandPalette to keep its prior backdrop treatment).

Refactors CommandInput to drop the wrapperClassName prop and instead applies submenu-specific wrapper classes via an external <div> in CommandPalette, avoiding wrapper styling being controlled inside the input component.

Reviewed by Cursor Bugbot for commit 968db3c. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Revert command palette backdrop to bg-background/60 with no blur

  • Reverts the default CommandDialogBackdrop styling from bg-background/60 back from the new bg-black/32 backdrop-blur-sm default by overriding it in CommandPalette via a new backdropClassName prop on CommandDialogPopup.
  • Removes the wrapperClassName prop from CommandInput, replacing it with a locally-scoped wrapper <div> in CommandPalette.tsx to apply submenu pointer/cursor styles.
  • Behavioral Change: CommandInput's wrapperClassName prop is no longer supported; the wrapper always uses fixed padding (px-2.5 py-1.5).

Macroscope summarized 968db3c.

- Restore command palette backdrop handling
- Lower toast stacking to avoid overlay conflicts
- Simplify command input wrapper handling
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 12, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 35dcfff1-85da-4a22-9dd2-b0788d1bfb9f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/revert-core-ui-palette

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 12, 2026
- Bump toast viewport and positioner z-index to 100
- Keep toasts above the reverted core UI palette
@github-actions github-actions bot added size:S 10-29 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Apr 12, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 12, 2026

Approvability

Verdict: Approved

This PR reverts visual styling for the command palette backdrop (blur effect, background color) and reorganizes CSS class application. These are purely cosmetic changes with no runtime behavior impact beyond appearance.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant