Revert core UI palette layering tweaks#1952
Conversation
- Restore command palette backdrop handling - Lower toast stacking to avoid overlay conflicts - Simplify command input wrapper handling
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
- Bump toast viewport and positioner z-index to 100 - Keep toasts above the reverted core UI palette
ApprovabilityVerdict: Approved This PR reverts visual styling for the command palette backdrop (blur effect, background color) and reorganizes CSS class application. These are purely cosmetic changes with no runtime behavior impact beyond appearance. You can customize Macroscope's approvability policy. Learn more. |
Summary
Testing
Note
Low Risk
Low risk UI-only changes that adjust dialog backdrop styling and slightly refactor command palette input layout; main risk is minor visual/regression in overlay appearance.
Overview
Updates the command palette dialog overlay styling by changing the default
CommandDialogBackdropto a darker, blurred backdrop and adding abackdropClassNameoverride onCommandDialogPopup(used byCommandPaletteto keep its prior backdrop treatment).Refactors
CommandInputto drop thewrapperClassNameprop and instead applies submenu-specific wrapper classes via an external<div>inCommandPalette, avoiding wrapper styling being controlled inside the input component.Reviewed by Cursor Bugbot for commit 968db3c. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Revert command palette backdrop to bg-background/60 with no blur
CommandDialogBackdropstyling frombg-background/60back from the newbg-black/32 backdrop-blur-smdefault by overriding it inCommandPalettevia a newbackdropClassNameprop onCommandDialogPopup.wrapperClassNameprop fromCommandInput, replacing it with a locally-scoped wrapper<div>in CommandPalette.tsx to apply submenu pointer/cursor styles.CommandInput'swrapperClassNameprop is no longer supported; the wrapper always uses fixed padding (px-2.5 py-1.5).Macroscope summarized 968db3c.