ci(github): exclude test files from mixed PR size calculation#1105
ci(github): exclude test files from mixed PR size calculation#1105binbandit wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This is obv up to Julius and Theo (and team), but if it were me I don't think I'd want this tbh. Tests still need to be reviewed, so if a PR adds a shitload of tests, the effort to review is still decently high, especially because of the crazy rate of shit and useless tests that LLM's love to write |
|
The problem is that a small change to add a tiny feature might need a whole new test file written. Tests are pretty effortless to review, but the actual implementation is more effort. So we should base the "size" on the actual feature / fix being added, and not base it on the tests. That being said, if the PR is to just add tests, then we will use that as a gauge for how large the PR is |
I agree, because of this it would be better to exclude test files from the labels, when the PR is not only for tests. |
What Changed
Why
Testing
Note
Exclude test files from PR size label calculation in mixed PRs
additions + deletionscount from the event payload with a per-file aggregation usingpulls.listFilesto detect and separate test vs. non-test changed lines.Macroscope summarized cfcbb25.