fix: use system claude binary in packaged Electron app#1189
Open
JustYannicc wants to merge 1 commit intopingdotgg:codething/648ca884-claudefrom
Open
fix: use system claude binary in packaged Electron app#1189JustYannicc wants to merge 1 commit intopingdotgg:codething/648ca884-claudefrom
JustYannicc wants to merge 1 commit intopingdotgg:codething/648ca884-claudefrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The claude-agent-sdk bundles its own cli.js inside node_modules. In the packaged Electron app this file lives inside the asar archive, where child_process.spawn cannot execute it — causing the Claude Code process to exit with code 1 immediately after session start. Default pathToClaudeCodeExecutable to "claude" (resolved via PATH) so the adapter uses the system-installed binary, matching how the Codex adapter already defaults to "codex". Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
69f1e25 to
12685fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Default
pathToClaudeCodeExecutableto"claude"(resolved via PATH) instead of leaving it unset, which lets the SDK fall back to its bundledcli.js.Why
The
claude-agent-sdkbundles its owncli.jsinsidenode_modules. In the packaged Electron app this file gets packed into the asar archive, wherechild_process.spawncannot execute it — the Claude Code process exits with code 1 immediately after session start.Using the system
claudebinary matches how the Codex adapter already defaults to"codex".Checklist
Note
Fix Claude binary path to default to system
claudein packaged Electron appIn
ClaudeAdapter.ts,pathToClaudeCodeExecutableis now always set inqueryOptions, defaulting to"claude"when nobinaryPathis provided. Previously, the field was omitted entirely whenbinaryPathwas absent, which caused the packaged Electron app to fail to locate the system Claude binary.Macroscope summarized 12685fb.