Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove source-map-support package in favor of native NodeJS support #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove source-map-support package in favor of native NodeJS support #145

wants to merge 1 commit into from

Conversation

schnz
Copy link

@schnz schnz commented Jul 22, 2024

Fixes #144

@kibertoad
Copy link
Contributor

What Node versions is this compatible with?

@schnz schnz force-pushed the bugfix/stacktrace branch from 1fbcf91 to 3f67079 Compare July 22, 2024 11:38
@schnz
Copy link
Author

schnz commented Jul 22, 2024 •
edited
Loading

Sorry, somehow the "engines.node" change in package.json didn't make it into the commit. Should be compatible with all node versions >= v12.

// Edit: >=v12.12.0 to be exact

@schnz schnz force-pushed the bugfix/stacktrace branch from 3f67079 to cccc817 Compare July 22, 2024 11:42
mcollina
mcollina approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I will bump a major

@mcollina mcollina requested review from jsumners and kibertoad July 22, 2024 14:01
@mcollina
Copy link
Member

CI is failing. Can you skip Node.js v14 on Mac OS X?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

@jsumners jsumners jsumners approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

source-map-support incompatible with tsx
4 participants
@schnz @kibertoad @mcollina @jsumners