Fixes issue with nested keys (#1198)

* fix: fixes issue with nested keys * chore: use strictSame in nested key test
pinojs · Oct 29, 2021 · 43906c7 · 43906c7
1 parent f19a27f
commit 43906c7
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/tools.js b/lib/tools.js
@@ -173,7 +173,7 @@ function asJson (obj, msg, num, time) {
     }
   }
 
-  if (this[nestedKeySym]) {
+  if (this[nestedKeySym] && propStr) {
     // place all the obj properties under the specified key
     // the nested key is already formatted from the constructor
     return data + this[nestedKeyStrSym] + propStr.slice(1) + '}' + msgStr + end

diff --git a/test/basic.test.js b/test/basic.test.js
@@ -712,3 +712,21 @@ test('correctly log number', async (t) => {
   const { msg } = await once(stream, 'data')
   t.equal(msg, 42)
 })
+
+test('nestedKey should not be used for non-objects', async ({ strictSame }) => {
+  const stream = sink()
+  const message = 'hello'
+  const nestedKey = 'stuff'
+  const instance = pino({
+    nestedKey
+  }, stream)
+  instance.info(message)
+  const result = await once(stream, 'data')
+  delete result.time
+  strictSame(result, {
+    pid,
+    hostname,
+    level: 30,
+    msg: message
+  })
+})