Do not write undefined properties.

pinojs · Mar 5, 2016 · 8c11772 · 8c11772
1 parent 7233a84
commit 8c11772
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/pino.js b/pino.js
@@ -99,7 +99,9 @@ function pino (opts, stream) {
         data += ',"type":"Error","stack":' + stringify(obj.stack) + '}'
       } else {
         for (var key in obj) {
-          data += ',"' + key + '":' + stringify(obj[key])
+          if (obj[key]) {
+            data += ',"' + key + '":' + stringify(obj[key])
+          }
         }
         data += '}'
       }

diff --git a/test.js b/test.js
@@ -206,3 +206,22 @@ test('set the level via constructor', function (t) {
   instance.error('this is an error')
   instance.fatal('this is fatal')
 })
+
+test('set undefined properties', function (t) {
+  t.plan(2)
+
+  var instance = pino(sink(function (chunk, enc, cb) {
+    t.ok(Date.parse(chunk.time) <= new Date(), 'time is greater than Date.now()')
+    delete chunk.time
+    t.deepEqual(chunk, {
+      pid: pid,
+      hostname: hostname,
+      level: 30,
+      hello: 'world',
+      v: 0
+    })
+    cb()
+  }))
+
+  instance.info({ hello: 'world', property: undefined })
+})