Add overload to handle unknown returned by TS-4.4 for errors be defau…

…lt (#1116)
pinojs · Sep 4, 2021 · a201e2c · a201e2c
1 parent 71a537c
commit a201e2c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -64,7 +64,7 @@
   },
   "homepage": "http://getpino.io",
   "devDependencies": {
-    "@types/node": "^16.7.2",
+    "@types/node": "^16.7.10",
     "airtap": "4.0.3",
     "benchmark": "^2.1.4",
     "bole": "^4.0.0",

diff --git a/pino.d.ts b/pino.d.ts
@@ -886,6 +886,7 @@ declare namespace P {
     interface LogFn {
         /* tslint:disable:no-unnecessary-generics */
         <T extends object>(obj: T, msg?: string, ...args: any[]): void;
+        (obj: unknown, msg?: string, ...args: any[]): void;
         (msg: string, ...args: any[]): void;
     }
 

diff --git a/test/types/pino.test-d.ts b/test/types/pino.test-d.ts
@@ -253,6 +253,12 @@ pino({ name: "my-logger" }, destinationViaStream);
 pino(destinationViaOptionsObject);
 pino({ name: "my-logger" }, destinationViaOptionsObject);
 
+try {
+    throw new Error('Some error')
+} catch (err) {
+    log.error(err)
+}
+
 interface StrictShape {
     activity: string;
     err?: unknown;