Make local-evaluation overridable at runtime #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a typo, SSH options would be ignored for `rebuild` when using `lollypops.deployment.local-evaluation = true`, `lollypops.deployment.sudo.enable = false`, and `lollypops.deployment.ssh.opts`. Since SSH options can be overriden at runtime, and having an empty NIX_SSHOPTS doesn't seem to be an issue, I removed the Nix-time switch altogether.
Adds an environment variable `LP_LOCAL_EVALUATION` which overrides `lollypops.deployment.local-evaluation` at runtime. Use case: Sometimes I'm deploying from my main workstation which is more powerful than the servers, so building locally makes sense. Other times I'm deploying from my crappy ARM laptop which is barely capable of building itself. I'd like to switch from one to the other without having to modify the flake of my system.
GeoffreyFrogeye
force-pushed
the
runtime-local-deployment
branch
from
56b232a to
703d55e
Compare
|
(Removed debugging echo) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a bug that should have been caught in #31 .
I'm not so sure about the variable name, most have the
LP_prefix but are undocumented, the only documented one (REBUILD_ACTION) doesn't have it. I went with what makes more sense to me (also, because I might actually remove the need fornevermind) but it's up for debate (well, as is everything in a PR I guess).REBUILD_ACTIONin my next PRThe code as-is hasn't been completely tested, remote evaluation without #33 is failing for me because it's trying to find my local development copy of lollypops.