Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fmtp parsing with spaces inside #192

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

Olex1313
Copy link
Contributor

@Olex1313 Olex1313 commented Jan 9, 2025

Description

Fix fmtp attribute parsing lines with extra spaces, details provided in the issue

Reference issue

Fixes #190

@jerry-tao jerry-tao merged commit 2194c96 into pion:master Jan 9, 2025
12 checks passed
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.96%. Comparing base (d518314) to head (f198008).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   64.96%   64.96%           
=======================================
  Files          12       12           
  Lines        1587     1587           
=======================================
  Hits         1031     1031           
  Misses        455      455           
  Partials      101      101           
Flag Coverage Δ
go 64.96% <100.00%> (ø)
wasm 64.96% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

parseFmtp fails when parameters are separated with a whitespace
2 participants