Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on conflicting codec values when parsing #199

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Conversation

Sean-Der
Copy link
Member

Resolves #198

@Sean-Der Sean-Der requested a review from tmatth March 10, 2025 03:56
@Sean-Der
Copy link
Member Author

Hey @tmatth does this capture what you wanted to see fixed?

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 85.36585% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.96%. Comparing base (c128a97) to head (b0fecba).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
util.go 85.36% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   65.59%   65.96%   +0.37%     
==========================================
  Files          12       12              
  Lines        1645     1660      +15     
==========================================
+ Hits         1079     1095      +16     
+ Misses        466      464       -2     
- Partials      100      101       +1     
Flag Coverage Δ
go 65.96% <85.36%> (+0.37%) ⬆️
wasm 65.78% <85.36%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@tmatth tmatth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg

@Sean-Der Sean-Der merged commit c7c57e2 into master Mar 10, 2025
15 checks passed
@Sean-Der Sean-Der deleted the issue-198 branch March 10, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

peerconnection: SetRemoteDescription should validate against inconsistent track and mimetypes
2 participants