Skip to content

adding a getter and types for AuthBundle #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

David-Botos
Copy link

No description provided.

@mattieruth
Copy link
Contributor

Apologies for silence on this. And thank you for taking the initiative of providing a PR instead of just posting an issue!

The authBundle type is dependent on the transport type, and may not even be used (see the OpenAIRealTimeWebRTCTransport as an example. So I don't think we can properly type it on the Client. The type you have spelled out in this PR is specific to the DailyTransport and is typed there.

Separately, since the AuthBundle is transport-specific, I think it makes sense to add the getter to the transport instead of the client. I'd like to understand the use case your solving for to make sure that a getter for the AuthBundle is what is really wanted (vs. getters for the room_url/token that is used). Once I understand the need, I will close this ticket and open a new one on the transports repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants