-
Notifications
You must be signed in to change notification settings - Fork 71
Warm transfer demo #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warm transfer demo #102
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
62d1535
to
2009bb0
Compare
5443a1c
to
aa77a95
Compare
aa77a95
to
bd91c5b
Compare
Note to self: do not rebase |
ee88d86
to
cc7737e
Compare
bd91c5b
to
022b377
Compare
cc7737e
to
b625df4
Compare
f1ddfc1
to
c775001
Compare
This is really great! While the logic is complex, it's relatively easy to follow along. (I wonder if we should think about adding conveniences to make controlling remote participants easier, especially for a customer/agent/bot scenario. That's for another PR though.) I've noticed that sometimes the
I'm running Pipecat 0.0.61 and Flows 0.0.16. One minor UX improvement might be to print the agent URL when it's time for the agent to join, rather than at the start of the session. Other that, this is really on the right track. Very impressive! 👏 |
… `CartesiaHttpTTSService` for now, to avoid an issue where interrupting the bot would cause post_actions to run before the bot stopped speaking (see #119)
…e refinement, to keep the demo simple
d95be75
to
6cdc179
Compare
6cdc179
to
81367b2
Compare
84d3d7f
to
7d1f6b7
Compare
7d1f6b7
to
ab0ca1f
Compare
…ions in a single call
…nts so they're easily distinguishable in the Daily Prebuilt UI
@@ -0,0 +1,7 @@ | |||
# Hold Music Player |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want the hold_music
folder to be within an assets
directory within examples
? Maybe examples/assets
? Rationale being that it isn't a demo in itself. It's an asset used by a Flows demo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
Just one question about where the hold_music should reside.
Plan: