chore: support the new genai endpoint format #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethjevans
force-pushed
the
support-new-endpoint-format
branch
from
512e802 to
2d2dfb2
Compare
garethjevans
force-pushed
the
support-new-endpoint-format
branch
from
2d2dfb2 to
e7cc3ae
Compare
teddyking
reviewed
Jun 11, 2025
| Map<String, String> endpoint = (Map<String, String>)cfCredentials.getMap().get("endpoint"); | ||
| properties.put("spring.ai.openai.chat.base-url", endpoint.get("api_base") + "/openai"); | ||
| properties.put("spring.ai.openai.chat.api-key", endpoint.get("api_key")); | ||
| properties.put("spring.ai.openai.chat.options.model", "tanzu://chat"); |
There was a problem hiding this comment.
If I understand correctly, this logic will always set the spring.ai.openai.chat.* properties for all bindings that contain the endpoint key, even if there is no chat-capable model behind the endpoint? Is that a problem? I guess that if an app were to make a chat request, it would receive some sort of 404 model not found response, which maybe is fine?
There was a problem hiding this comment.
I guess this would only be an issue if the app / spring ai attempts to test connectivity to all configured models at startup 🤔
| Map<String, String> endpoint = (Map<String, String>)cfCredentials.getMap().get("endpoint"); | ||
| properties.put("spring.ai.openai.embedding.base-url", endpoint.get("api_base") + "/openai"); | ||
| properties.put("spring.ai.openai.embedding.api-key", endpoint.get("api_key")); | ||
| properties.put("spring.ai.openai.embedding.options.model", "tanzu://embedding"); |
There was a problem hiding this comment.
Same note as above, this will always try to configure an embedding model, even when there is none.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the 10.1.0 genai tile release, there is a new binding format. This PR adds support for the new format, whilst retaining compatibility for the old format