-
Notifications
You must be signed in to change notification settings - Fork 0
Update "PixelGenius Platform" from zeroheight #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e735fde
2a3a6bc
4b180a3
73256c0
674bcb4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -29,6 +29,14 @@ | |||||||||||||
| --ring: var(--zinc-600); | ||||||||||||||
| --secondary: var(--zinc-800); | ||||||||||||||
| --secondary-foreground: var(--general-white); | ||||||||||||||
| --sidebar: var(--color-card); | ||||||||||||||
| --sidebar-accent: var(--color-background); | ||||||||||||||
| --sidebar-accent-foreground: var(--color-foreground); | ||||||||||||||
| --sidebar-border: rgba(255, 255, 255, 0.0000); | ||||||||||||||
| --sidebar-forground: var(--color-foreground); | ||||||||||||||
| --sidebar-primary: #ff0000; | ||||||||||||||
| --sidebar-primary-foreground: #ff0000; | ||||||||||||||
| --sidebar-ring: #ff0000; | ||||||||||||||
|
Comment on lines
+37
to
+39
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Replace placeholder red colors with proper design tokens. The hardcoded - --sidebar-primary: #ff0000;
- --sidebar-primary-foreground: #ff0000;
- --sidebar-ring: #ff0000;
+ --sidebar-primary: var(--primary);
+ --sidebar-primary-foreground: var(--primary-foreground);
+ --sidebar-ring: var(--ring);📝 Committable suggestion
Suggested change
|
||||||||||||||
| --success: var(--emerald-500); | ||||||||||||||
| --success-border: var(--green-900); | ||||||||||||||
| --success-foreground: var(--green-50); | ||||||||||||||
|
|
||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,6 +29,14 @@ | |
| --ring: var(--zinc-400); | ||
| --secondary: var(--zinc-100); | ||
| --secondary-foreground: var(--zinc-900); | ||
| --sidebar: var(--color-card); | ||
| --sidebar-accent: var(--color-background); | ||
| --sidebar-accent-foreground: var(--color-foreground); | ||
|
Comment on lines
+32
to
+34
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix incorrect CSS variable references. The variables reference non-existent - --sidebar: var(--color-card);
- --sidebar-accent: var(--color-background);
- --sidebar-accent-foreground: var(--color-foreground);
- --sidebar-forground: var(--color-foreground);
+ --sidebar: var(--card);
+ --sidebar-accent: var(--background);
+ --sidebar-accent-foreground: var(--foreground);
+ --sidebar-foreground: var(--foreground);Also applies to: 36-36 |
||
| --sidebar-border: rgba(255, 255, 255, 0.0000); | ||
| --sidebar-forground: var(--color-foreground); | ||
| --sidebar-primary: #ff0000; | ||
| --sidebar-primary-foreground: #ff0000; | ||
| --sidebar-ring: #ff0000; | ||
|
Comment on lines
+37
to
+39
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Replace placeholder red colors with proper design tokens. The hardcoded - --sidebar-primary: #ff0000;
- --sidebar-primary-foreground: #ff0000;
- --sidebar-ring: #ff0000;
+ --sidebar-primary: var(--primary);
+ --sidebar-primary-foreground: var(--primary-foreground);
+ --sidebar-ring: var(--ring); |
||
| --success: var(--green-100); | ||
| --success-border: var(--green-200); | ||
| --success-foreground: var(--green-700); | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -26,6 +26,14 @@ export const colors = { | |||||
| "ring": "hsl(var(--ring))", | ||||||
| "secondary": "hsl(var(--secondary))", | ||||||
| "secondary-foreground": "hsl(var(--secondary-foreground))", | ||||||
| "sidebar": "hsl(var(--sidebar))", | ||||||
| "sidebar-accent": "hsl(var(--sidebar-accent))", | ||||||
| "sidebar-accent-foreground": "hsl(var(--sidebar-accent-foreground))", | ||||||
| "sidebar-border": "hsl(var(--sidebar-border))", | ||||||
| "sidebar-forground": "hsl(var(--sidebar-forground))", | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix typo in color token name. The token name contains a typo: "forground" should be "foreground". - "sidebar-forground": "hsl(var(--sidebar-forground))",
+ "sidebar-foreground": "hsl(var(--sidebar-foreground))",📝 Committable suggestion
Suggested change
|
||||||
| "sidebar-primary": "hsl(var(--sidebar-primary))", | ||||||
| "sidebar-primary-foreground": "hsl(var(--sidebar-primary-foreground))", | ||||||
| "sidebar-ring": "hsl(var(--sidebar-ring))", | ||||||
| "success": "hsl(var(--success))", | ||||||
| "success-border": "hsl(var(--success-border))", | ||||||
| "success-foreground": "hsl(var(--success-foreground))", | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "LG": { | ||
| "$type": "number", | ||
| "$value": 24 | ||
| }, | ||
| "MD": { | ||
| "$type": "number", | ||
| "$value": 18 | ||
| }, | ||
| "XS": { | ||
| "$type": "number", | ||
| "$value": 16 | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,200 @@ | ||
| { | ||
| "Text-black": { | ||
| "$type": "color", | ||
| "$value": "#1a1a20" | ||
| }, | ||
| "font": { | ||
| "family": { | ||
| "Font Family": { | ||
| "$type": "string", | ||
| "$value": "Poppins" | ||
| } | ||
| }, | ||
| "line height": { | ||
| "Display": { | ||
| "LG": { | ||
| "$type": "number", | ||
| "$value": 112 | ||
| }, | ||
| "MD": { | ||
| "$type": "number", | ||
| "$value": 64 | ||
| }, | ||
| "SM": { | ||
| "$type": "number", | ||
| "$value": 52 | ||
| }, | ||
| "XS": { | ||
| "$type": "number", | ||
| "$value": 44 | ||
| } | ||
| }, | ||
| "Heading": { | ||
| "LG": { | ||
| "$type": "number", | ||
| "$value": 40 | ||
| }, | ||
| "MD": { | ||
| "$type": "number", | ||
| "$value": 36 | ||
| }, | ||
| "SM": { | ||
| "$type": "number", | ||
| "$value": 32 | ||
| }, | ||
| "XL": { | ||
| "$type": "number", | ||
| "$value": 44 | ||
| }, | ||
| "XS": { | ||
| "$type": "number", | ||
| "$value": 28 | ||
| }, | ||
| "XXL": { | ||
| "$type": "number", | ||
| "$value": 52 | ||
| } | ||
| }, | ||
| "Labels": { | ||
| "LG": { | ||
| "$type": "number", | ||
| "$value": 24 | ||
| }, | ||
| "MD": { | ||
| "$type": "number", | ||
| "$value": 20 | ||
| }, | ||
| "SM": { | ||
| "$type": "number", | ||
| "$value": 16 | ||
| }, | ||
| "XS": { | ||
| "$type": "number", | ||
| "$value": 16 | ||
| } | ||
| }, | ||
| "Paragraphs": { | ||
| "LG": { | ||
| "$type": "number", | ||
| "$value": 28 | ||
| }, | ||
| "MD": { | ||
| "$type": "number", | ||
| "$value": 24 | ||
| }, | ||
| "SM": { | ||
| "$type": "number", | ||
| "$value": 20 | ||
| }, | ||
| "XS": { | ||
| "$type": "number", | ||
| "$value": 20 | ||
| } | ||
| } | ||
| }, | ||
| "size": { | ||
| "Display": { | ||
| "LG": { | ||
| "$type": "number", | ||
| "$value": 96 | ||
| }, | ||
| "MD": { | ||
| "$type": "number", | ||
| "$value": 52 | ||
| }, | ||
| "SM": { | ||
| "$type": "number", | ||
| "$value": 44 | ||
| }, | ||
| "XS": { | ||
| "$type": "number", | ||
| "$value": 36 | ||
| } | ||
| }, | ||
| "Heading": { | ||
| "LG": { | ||
| "$type": "number", | ||
| "$value": 32 | ||
| }, | ||
| "MD": { | ||
| "$type": "number", | ||
| "$value": 28 | ||
| }, | ||
| "SM": { | ||
| "$type": "number", | ||
| "$value": 24 | ||
| }, | ||
| "XL": { | ||
| "$type": "number", | ||
| "$value": 36 | ||
| }, | ||
| "XS": { | ||
| "$type": "number", | ||
| "$value": 20 | ||
| }, | ||
| "XXL": { | ||
| "$type": "number", | ||
| "$value": 40 | ||
| } | ||
| }, | ||
| "Labels": { | ||
| "LG": { | ||
| "$type": "number", | ||
| "$value": 18 | ||
| }, | ||
| "MD": { | ||
| "$type": "number", | ||
| "$value": 16 | ||
| }, | ||
| "SM": { | ||
| "$type": "number", | ||
| "$value": 14 | ||
| }, | ||
| "XS": { | ||
| "$type": "number", | ||
| "$value": 12 | ||
| } | ||
| }, | ||
| "Paragraphs": { | ||
| "LG": { | ||
| "$type": "number", | ||
| "$value": 18 | ||
| }, | ||
| "MD": { | ||
| "$type": "number", | ||
| "$value": 16 | ||
| }, | ||
| "SM": { | ||
| "$type": "number", | ||
| "$value": 14 | ||
| }, | ||
| "XS": { | ||
| "$type": "number", | ||
| "$value": 12 | ||
| }, | ||
| "XXS": { | ||
| "$type": "number", | ||
| "$value": 10 | ||
| } | ||
| } | ||
| }, | ||
| "weight": { | ||
| "Bold": { | ||
| "$type": "string", | ||
| "$value": "Bold" | ||
| }, | ||
| "Medium": { | ||
| "$type": "string", | ||
| "$value": "Medium" | ||
| }, | ||
| "Regular": { | ||
| "$type": "string", | ||
| "$value": "Regular" | ||
| }, | ||
| "light": { | ||
| "$type": "string", | ||
| "$value": "Light" | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix incorrect CSS variable references.
The variables reference non-existent
--color-*variables. They should reference the corresponding base variables instead.Also applies to: 36-36