[Issue #1068] investigate issues with Retina under high concurrency #1069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengdy1545
force-pushed
the
chore/updateRetinaTest
branch
from
61c7967 to
1293f65
Compare
AntiO2
reviewed
Oct 14, 2025
| colNames = new String[]{"key", "name", "region", "comment"}; | ||
| MetadataService metadataService = MetadataService.Instance(); | ||
|
|
||
| String keyColumn = "{\"keyColumnIds\":[25]}"; |
There was a problem hiding this comment.
We can automatically construct the keyColumn string here, so we don’t need to hardcode it, making the tests more portable.
You can refer to the two code segments in Trino related to creating an index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following tests have been added: