Skip to content

Conversation

whzruc
Copy link
Collaborator

@whzruc whzruc commented Oct 4, 2025

1.update pxiels-extension
2. bufferpool
3. hugepage
4. update pixels-cpp.properties

@whzruc whzruc added this to the Pixels C++ milestone Oct 4, 2025
@whzruc whzruc requested a review from yuly16 October 4, 2025 11:50
@whzruc whzruc self-assigned this Oct 4, 2025
@whzruc whzruc added the enhancement New feature or request label Oct 4, 2025
@whzruc whzruc linked an issue Oct 4, 2025 that may be closed by this pull request
@bianhq bianhq changed the title Feature/huge page [Issue #973] implement a buffer pool for pixels cpp Oct 4, 2025
* License along with Pixels. If not, see
* <https://www.gnu.org/licenses/>.
*/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove one empty line.

length = length_;
this->bufferId = bufferId;
Request::Request(uint64_t queryId_, uint64_t start_, uint64_t length_,
int64_t bufferId) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{ in the next line.

template <class U>
constexpr huge_page_allocator(const huge_page_allocator<U> &) noexcept {}

size_t round_to_huge_page_size(size_t n) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{ in the next line.

}

// Prints information about the mutex owner
void print_owner(const std::mutex* mutex, const std::string& mutex_name) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[pixels-cpp] implementation of bufferpool manager

2 participants