ci: fix release #30
Open
ci: fix release #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a bug in the release workflow for macOS by removing an unnecessary deployment target and ensuring the correct artifacts are committed and built. The key changes include:
- Updating the Git commit command to include Cargo.lock.
- Correcting the version variable interpolation syntax in the release notes generation step.
- Changing the cross-compilation linker for aarch64-apple-darwin from gcc to clang.
Comments suppressed due to low confidence (1)
.github/workflows/release.yml:165
- Ensure that clang is installed and properly configured on the runner for the aarch64-apple-darwin target, as this change may result in build failures if clang is unavailable.
CARGO_TARGET_AARCH64_APPLE_DARWIN_LINKER: clang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Check this: rust-lang/cargo#13115 (comment)
Also check this
we need not explicitly pass the deployment target.
Context
release especially when building for mac failed here.
How did you test it?
release should happen.
Checklist
cargo +nightly fmt --allcargo clippy