Skip to content

Assignment 1 Full submission Apr27#3

Open
pjain1357 wants to merge 6 commits into
mainfrom
assignment-1
Open

Assignment 1 Full submission Apr27#3
pjain1357 wants to merge 6 commits into
mainfrom
assignment-1

Conversation

@pjain1357
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Added code

What did you learn from the changes you have made?

A lot , task generation, evaluation

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Not yet , I m still learning

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Yes, coding and logic. To overcome these I had to look into resources and lab work and videos too.

How were these changes tested?

Executed the file locally

A reference to a related issue in your repository (if applicable)

NA

Checklist

  • [ YES] I can confirm that my changes are working as intended

Copy link
Copy Markdown

@Dmytro-Bonislavskyi Dmytro-Bonislavskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pjain1357 looks like you forgot to add "f" in "context" so {docs} will stay as plain text instead of inserting the variable.


instruction = f"""
                "You are a technical analyst. Generate a structured response based on the provided text.
              "The 'summary' field must be written strictly in the following tone: {model_tone}. 
              "The 'relevance' field should focus on the professional development of an AI Engineer.
        """

context = (
        "Analyze the following article content: {docs}. "
        "Focus on the core concepts of identifying strengths, working styles, and values."
    )

It should be:


context = f(
"Analyze the following article content: {docs}. ".....

Otherwise model will miss your "docs"

Copy link
Copy Markdown

@Dmytro-Bonislavskyi Dmytro-Bonislavskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved.

@pjain1357
Copy link
Copy Markdown
Owner Author

Thanks @Dmytro-Bonislavskyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants