Assignment 2#4
Open
pjain1357 wants to merge 2 commits into
Open
Conversation
Dmytro-Bonislavskyi
approved these changes
May 6, 2026
Dmytro-Bonislavskyi
left a comment
There was a problem hiding this comment.
Hi @pjain1357 I can accept it as a partial submission, but I see a few important issues:
The README has a section for “Service 2: Semantic Query,” but there is no ChromaDB, embeddings, or vector search implementation in the submitted files. Also, convert_currency should probably be decorated with @tool, like the museum tools, so it works consistently inside LangGraph. One more small cleanup: gurdrails.py looks misspelled and does not seem to be used by app.py, so the guardrails should be connected more clearly. Good direction overall.
Owner
Author
|
Thanks @Dmytro-Bonislavskyi for your valuable feedback. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Added assignmet_chat for assignment 2 in assignemt-2 branch
What did you learn from the changes you have made?
Different tools to interact with the model and generate output
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Various tools and their implementation
How were these changes tested?
By running on my local machine
A reference to a related issue in your repository (if applicable)
Checklist