Skip to content

Assignment 2#4

Open
pjain1357 wants to merge 2 commits into
mainfrom
assignment-2
Open

Assignment 2#4
pjain1357 wants to merge 2 commits into
mainfrom
assignment-2

Conversation

@pjain1357
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Added assignmet_chat for assignment 2 in assignemt-2 branch

What did you learn from the changes you have made?

Different tools to interact with the model and generate output

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Various tools and their implementation

How were these changes tested?

By running on my local machine

A reference to a related issue in your repository (if applicable)

Checklist

  • [yes ] I can confirm that my changes are working as intended

Copy link
Copy Markdown

@Dmytro-Bonislavskyi Dmytro-Bonislavskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pjain1357 I can accept it as a partial submission, but I see a few important issues:

The README has a section for “Service 2: Semantic Query,” but there is no ChromaDB, embeddings, or vector search implementation in the submitted files. Also, convert_currency should probably be decorated with @tool, like the museum tools, so it works consistently inside LangGraph. One more small cleanup: gurdrails.py looks misspelled and does not seem to be used by app.py, so the guardrails should be connected more clearly. Good direction overall.

@pjain1357
Copy link
Copy Markdown
Owner Author

Thanks @Dmytro-Bonislavskyi for your valuable feedback.
I will take care of these things.
Did my assignment 1 considered as full submission?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants