Skip to content

structured citations #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

structured citations #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions CrossrefReferenceLinkingPlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,8 @@
use Citation;
use Doi;
use DOMDocument;
use PKP\citation\CitationDAO;
use PKP\context\Context;
use PKP\core\JSONMessage;
use PKP\db\DAORegistry;
use PKP\linkAction\LinkAction;
use PKP\linkAction\request\AjaxModal;
use PKP\plugins\GenericPlugin;
Expand Down Expand Up @@ -56,7 +54,6 @@ public function register($category, $path, $mainContextId = null): bool

// Additional fields added
Hook::add('Schema::get::submission', [$this, 'addSubmissionSchema']);
Hook::add('citationdao::getAdditionalFieldNames', [$this, 'getAdditionalCitationFieldNames']);

if (!$this->getEnabled($mainContextId)) {
return true;
Expand Down Expand Up @@ -345,11 +342,10 @@ public function considerFoundCrossrefReferencesDOIs(Publication $publication): v
return;
}

$citationDao = DAORegistry::getDAO('CitationDAO'); /** @var CitationDAO $citationDao */
$citations = $publication->getData('citations') ?? [];
$citations = Repo::citation()->getByPublicationId($publication->getId());

$citationsToCheck = [];
foreach ($citations as $citation) { /** @var Citation $citation */
foreach ($citations as $citation) {
if (!$citation->getData($this->getCitationDoiSettingName())) {
$citationsToCheck[$citation->getId()] = $citation;
}
Expand All @@ -372,7 +368,7 @@ public function considerFoundCrossrefReferencesDOIs(Publication $publication): v
foreach ($filteredMatchedReferences as $matchedReference) {
$citation = $citationsToCheck[$matchedReference['key']];
$citation->setData($this->getCitationDoiSettingName(), $matchedReference['doi']);
$citationDao->updateObject($citation);
Repo::citation()->edit($citation, []);
}

// remove auto check setting
Expand Down