Skip to content

pkp/pkp-lib#10929 Production editor adding a file and updating article text receives an access denied 401 error #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vitaliy-1 merged 2 commits into from
May 28, 2025
Merged

pkp/pkp-lib#10929 Production editor adding a file and updating article text receives an access denied 401 error #930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88d520a
pkp/pkp-lib#10929 Temporary fix - implement app level SubmissionHandl…
taslangraham Apr 16, 2025
cdc90c5
Submodule update
taslangraham Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/pkp
Open in desktop
Submodule pkp updated 4 files
+1 −1 api/v1/submissions/PKPSubmissionController.php
+10 −0 classes/components/forms/submission/StartSubmission.php
+2 −0 classes/submission/reviewer/form/PKPReviewerReviewStep3Form.php
+22 −15 pages/submission/PKPSubmissionHandler.php
37 changes: 37 additions & 0 deletions pages/submission/SubmissionHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
use APP\section\Section;
use APP\submission\Submission;
use APP\template\TemplateManager;
use Illuminate\Support\Collection;
use Illuminate\Support\LazyCollection;
use PKP\components\forms\FormComponent;
use PKP\components\forms\publication\Details;
Expand All @@ -36,7 +37,10 @@
use PKP\facades\Locale;
use PKP\pages\submission\PKPSubmissionHandler;
use PKP\plugins\Hook;
use PKP\security\Role;
use PKP\submission\GenreDAO;
use PKP\user\User;
use PKP\userGroup\UserGroup;

class SubmissionHandler extends PKPSubmissionHandler
{
Expand Down Expand Up @@ -295,4 +299,37 @@ protected function getConfirmSubmitMessage(Submission $submission, Context $cont
}
return __('submission.wizard.confirmSubmit', ['context' => $context->getLocalizedName()]);
}

/**
* Get the user groups that a user can submit in
*/
protected function getSubmitUserGroups(Context $context, User $user): Collection
{
$userGroups = UserGroup::query()
->withContextIds([$context->getId()])
->withUserIds([$user->getId()])
->whereHas('userUserGroups', function ($query) use ($user) {
$query->withUserId($user->getId())->withActive();
})
->withRoleIds([Role::ROLE_ID_MANAGER, Role::ROLE_ID_SITE_ADMIN, Role::ROLE_ID_AUTHOR])
->get();

// Users without a submitting role can submit as an
// author role that allows self registration
if ($userGroups->isEmpty()) {
Repo::userGroup()->assignUserToGroup(
$user->getId(),
Repo::userGroup()->getByRoleIds([Role::ROLE_ID_AUTHOR], $context->getId())->first()->id
);

$defaultUserGroup = UserGroup::withContextIds([$context->getId()])
->withRoleIds([Role::ROLE_ID_AUTHOR])
->permitSelfRegistration(true)
->first();

$userGroups = collect($defaultUserGroup ? [$defaultUserGroup->id => $defaultUserGroup] : []);
}

return $userGroups;
}
}