Skip to content

pkp/pkp-lib#9295 publishing without issue assignment in editorial workflow #11385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pkp/pkp-lib#9295 publishing without issue assignment in editorial workflow #11385

wants to merge 1 commit into from

Conversation

touhidurabir
Copy link
Member

for #9295 .

@touhidurabir touhidurabir mentioned this pull request May 12, 2025
Open
@touhidurabir touhidurabir force-pushed the i9295_main branch 2 times, most recently from 86e6c39 to 710f9dc Compare May 20, 2025 06:43
@touhidurabir touhidurabir force-pushed the i9295_main branch 5 times, most recently from 3bafc12 to c765505 Compare May 29, 2025 08:42
asmecher
asmecher requested changes May 29, 2025
View reviewed changes
api/v1/submissions/PKPSubmissionController.php Outdated
@@ -1273,6 +1273,11 @@ public function editPublication(Request $illuminateRequest): JsonResponse
return response()->json($errors, Response::HTTP_BAD_REQUEST);
}

// If no issue is selected, it will be considered as continuous publication
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, any references to issueId should be kept in the OJS codebase. (There are a few places where we aren't 100% tidy with this.)

Copy link
Member Author

@touhidurabir touhidurabir Jun 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I was having a bit trouble where to move this part without duplicating a lot of code but now it's fine as moved to repository with different check and implementation .

@touhidurabir touhidurabir marked this pull request as ready for review May 30, 2025 12:23
@touhidurabir
pkp#9295 publishing without issue assignment in editorial workflow
56b4c4c 
pkp#9295 mute php 8.4 annoying deprecation warning

pkp#9295 remove context level settings named continuousPublication

pkp#9295 removed unused methods

pkp#9295 removed issue checking in core lib controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmecher asmecher asmecher requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@touhidurabir @asmecher