Add a Hook for PKPReviewerReviewStep3Form::saveForLater() for stable_3_5_0 #11404
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmecher
reviewed
May 27, 2025
| @@ -277,6 +278,7 @@ public function saveForLater() | |||
| 'recommendation' => (int) $this->getData('recommendation'), // save the recommendation to the review assignment | |||
| ]); | |||
|
|
|||
| Hook::call(strtolower_codesafe(get_class($this)) . '::saveForLater', array($this)); | |||
There was a problem hiding this comment.
As of PHP8.2, the PHP strtolower function is no longer locale-dependent, so we've removed the strtolower_codesafe function from our codebase in stable-3_5_0 and main. Use strtolower instead. Also, the [ ... ] syntax is preferred to array( ... ).
Suggested change
| Hook::call(strtolower_codesafe(get_class($this)) . '::saveForLater', array($this)); | |
| Hook::call(strtolower(get_class($this)) . '::saveForLater', [$this]); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11305