pkp/pkp-lib#11389 Validate contributor user group role is author before allowing add or edit in API #11412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vitaliy-1
requested changes
May 21, 2025
There was a problem hiding this comment.
Thanks, @Hafsa-Naeem!
I left comments that would require small adjustment.
| $userGroup = Repo::userGroup()->get($params['userGroupId']); | ||
| if (!$userGroup || $userGroup->roleId !== Role::ROLE_ID_AUTHOR) { | ||
| return response()->json([ | ||
| 'userGroupId' => [__('api.submission.400.invalidUserGroup', ['userGroupId' => $params['userGroupId']])] |
There was a problem hiding this comment.
Localisation is needed for the error message
There was a problem hiding this comment.
Probably, api.contributors.400.invalidUserGroup would be better
There was a problem hiding this comment.
@Vitaliy-1 Thanks! I’ve updated the error message to use the existing localized string:
submission.upload.invalidUserGroup -> “Missing or invalid user group!”
since it’s already defined in submission.po If you’d prefer a contributor-specific message like api.contributors.400.invalidUserGroup, I can add that too, just didn’t want to introduce a new locale key unless necessary. Let me know what you prefer!
Hafsa-Naeem
force-pushed
the
i11389-stable_3_5_0_fix
branch
from
c990a67 to
894060d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #11389