Skip to content

pkp/pkp-lib#11296 Remove unMounted when adding form fields to workflow form #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pkp/pkp-lib#11296 Remove unMounted when adding form fields to workflow form #694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 45 additions & 49 deletions src/pages/workflow/composables/useWorkflowVersionForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {onMounted, watch} from 'vue';
import {watch} from 'vue';
import {useUrl} from '@/composables/useUrl';
import {useForm} from '@/composables/useForm';
import {useFetch} from '@/composables/useFetch';
Expand Down Expand Up @@ -233,61 +233,57 @@ export function useWorkflowVersionForm(
});
addGroup('default');

onMounted(() => {
latestPublication = getLatestPublication(store.submission);
publications = store.submission?.publications || [];

// Send To field (only visible when sending file to text editor)
if (modeState.isTextEditorMode) {
addFieldSelect('sendToVersion', {
label: t('publication.sendToTextEditor.label'),
options: buildPublicationOptions({withCreateOption: true}),
size: 'large',
isRequired: modeState.isTextEditorMode,
showWhen: !modeState.isTextEditorMode ? [] : undefined,
});
}
latestPublication = getLatestPublication(store.submission);
publications = store.submission?.publications || [];

// Version source field (only visible when creating a new version, either via Create New Version button or Send to Text Editor when Send to File field "create" option is selected)
addFieldSelect('versionSource', {
label: t('publication.versionSource.create.label'),
description: t('publication.versionSource.create.description'),
options: buildPublicationOptions(),
// Send To field (only visible when sending file to text editor)
if (modeState.isTextEditorMode) {
addFieldSelect('sendToVersion', {
label: t('publication.sendToTextEditor.label'),
options: buildPublicationOptions({withCreateOption: true}),
size: 'large',
showWhen: !modeState.isCreateMode
? ['sendToVersion', 'create']
: undefined,
});

// Version stage field is required when form is in publish mode for "Unassigned Version"
// If sendToEditor mode, only show this field if the selected sendTo version is an "Unassigned version"
addFieldSelect('versionStage', {
label: t('publication.versionStage.label'),
description: t('publication.versionStage.description'),
options: store.versionStageOptions,
size: 'large',
isRequired: modeState.isPublishMode,
showWhen: modeState.isTextEditorMode
? ['sendToVersion', getUnassignedVersions()]
: undefined,
isRequired: modeState.isTextEditorMode,
showWhen: !modeState.isTextEditorMode ? [] : undefined,
});
}

// Version significance field
// If sendToEditor mode, only show this field if the selected sendTo version is an "Unassigned version"
addFieldSelect(
'versionIsMinor',
getVersionIsMinorField({
allowMinorVersion: true,
currentValue: '',
}),
);
// Version source field (only visible when creating a new version, either via Create New Version button or Send to Text Editor when Send to File field "create" option is selected)
addFieldSelect('versionSource', {
label: t('publication.versionSource.create.label'),
description: t('publication.versionSource.create.description'),
options: buildPublicationOptions(),
size: 'large',
showWhen: !modeState.isCreateMode ? ['sendToVersion', 'create'] : undefined,
});

setValue(
'versionSource',
modeState.isCreateMode ? latestPublication?.id : null,
);
// Version stage field is required when form is in publish mode for "Unassigned Version"
// If sendToEditor mode, only show this field if the selected sendTo version is an "Unassigned version"
addFieldSelect('versionStage', {
label: t('publication.versionStage.label'),
description: t('publication.versionStage.description'),
options: store.versionStageOptions,
size: 'large',
isRequired: modeState.isPublishMode,
showWhen: modeState.isTextEditorMode
? ['sendToVersion', getUnassignedVersions()]
: undefined,
});

// Version significance field
// If sendToEditor mode, only show this field if the selected sendTo version is an "Unassigned version"
addFieldSelect(
'versionIsMinor',
getVersionIsMinorField({
allowMinorVersion: true,
currentValue: '',
}),
);

setValue(
'versionSource',
modeState.isCreateMode ? latestPublication?.id : null,
);

watch(
() => getField('versionStage')?.value,
(newStage) => {
Expand Down