-
Notifications
You must be signed in to change notification settings - Fork 52
create reviewer invitation steps #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ipula
wants to merge
6
commits into
pkp:main
Choose a base branch
from
ipula:reviewer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
72dcd93
update reviewer invitation
ipula 2f13f94
add invitation types
ipula c577c26
add reviewer mockups
ipula 95c3b61
add submissionId and reviewRoundId to the payload
ipula 8df9024
add redirect route to select reviewer button
ipula 15ca5ad
hide add new role for already reviewers
ipula File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
<template> | ||
<FieldOptions | ||
:is-required="false" | ||
component="field-options" | ||
name="reviewTypes" | ||
:label="t('reviewerInvitation.reviewTypes')" | ||
type="radio" | ||
:options="options" | ||
:all-errors="sectionErrors" | ||
@change=" | ||
(fieldName, propName, newValue, localeKey) => | ||
updateReviewDetails(index, fieldName, newValue) | ||
" | ||
/> | ||
<div class="p-8"> | ||
<FieldText | ||
name="responseDueDate" | ||
:label="t('reviewerInvitation.responseDueDate')" | ||
input-type="date" | ||
:is-required="true" | ||
value="" | ||
:all-errors="sectionErrors" | ||
@change=" | ||
(fieldName, propName, newValue, localeKey) => | ||
updateReviewDetails(index, fieldName, newValue) | ||
" | ||
/> | ||
<FieldText | ||
name="reviewDueDate" | ||
:label="t('reviewerInvitation.reviewDueDate')" | ||
input-type="date" | ||
:is-required="true" | ||
value="" | ||
:all-errors="sectionErrors" | ||
@change=" | ||
(fieldName, propName, newValue, localeKey) => | ||
updateReviewDetails(index, fieldName, newValue) | ||
" | ||
/> | ||
</div> | ||
</template> | ||
<script setup> | ||
import {defineProps, computed} from 'vue'; | ||
import FieldOptions from '@/components/Form/fields/FieldOptions.vue'; | ||
import FieldText from '@/components/Form/fields/FieldText.vue'; | ||
import {useLocalize} from '@/composables/useLocalize'; | ||
import {useUserInvitationPageStore} from './UserInvitationPageStore'; | ||
|
||
const props = defineProps({ | ||
validateFields: {type: Array, required: true}, | ||
}); | ||
|
||
const store = useUserInvitationPageStore(); | ||
const {t} = useLocalize(); | ||
const options = [ | ||
{ | ||
value: 'anonymus', | ||
label: t('reviewerInvitation.reviewTypes.anonymusAuthorOrReviewer'), | ||
}, | ||
{ | ||
value: 'disclosed', | ||
label: t('reviewerInvitation.reviewTypes.disclosedAuthor'), | ||
}, | ||
{value: 'open', label: t('reviewerInvitation.reviewTypes.open')}, | ||
]; | ||
|
||
props.validateFields.forEach((field) => { | ||
store.updatePayload(field, '', false); | ||
}); | ||
|
||
function updateReviewDetails(index, fieldName, newValue) { | ||
delete store.errors[fieldName]; | ||
store.updatePayload(fieldName, newValue, false); | ||
} | ||
|
||
const sectionErrors = computed(() => { | ||
return props.validateFields.reduce((obj, key) => { | ||
if (store.errors[key]) { | ||
obj[key] = store.errors[key]; | ||
} | ||
return obj; | ||
}, {}); | ||
}); | ||
</script> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please do this using the Form component?
When possible we still want to stick with forms as much as possible. Cherry-picking form component is currently used only for unusual scenarios, like having fields in the table etc.. And this looks like good fit for form.
Good news is that you don't have to build this one server side anymore. useForm now has bunch of addField* method to support some basic form fields. You can see example of using that for example in
useDiscussionManagerForm
.