-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orders API Client Support For Multiple Fallback Bundle(s) #1106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great and will fulfill the feature request, thank you! I had a couple suggestions about docstrings and a suggestion to cover the fallback_bundle: list[str]
case in the tests added in this PR, but nothing functional to change. Nice work and thanks for incorporating into the user guide!
GH Ticket: #1105
This MR adds support in the Orders SDK and CLI for specifying multiple fallback bundles, updates the docs, and updates the orders CLI and SDK tests with success and failure cases for fallback bundles.
CLI example:
SDK example: