Orders API Client Support For Multiple Fallback Bundle(s)#1106
Merged
asonnenschein merged 10 commits intomainfrom Mar 21, 2025
Merged
Orders API Client Support For Multiple Fallback Bundle(s)#1106asonnenschein merged 10 commits intomainfrom
asonnenschein merged 10 commits intomainfrom
Conversation
pl-gideon
approved these changes
Mar 20, 2025
ceholden
reviewed
Mar 20, 2025
ceholden
left a comment
There was a problem hiding this comment.
I think this looks great and will fulfill the feature request, thank you! I had a couple suggestions about docstrings and a suggestion to cover the fallback_bundle: list[str] case in the tests added in this PR, but nothing functional to change. Nice work and thanks for incorporating into the user guide!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH Ticket: #1105
This MR adds support in the Orders SDK and CLI for specifying multiple fallback bundles, updates the docs, and updates the orders CLI and SDK tests with success and failure cases for fallback bundles.
CLI example:
SDK example: