feat: add item coverage and asset management in DataClient#1109
feat: add item coverage and asset management in DataClient#1109
Conversation
a632f22 to
9785a08
Compare
|
looks good so far! one thing we've been trying to do w/ tests is combine the sync/async calls into a single case since the setup and assertions are the same, the only difference is in invocation... see |
thanks @ischneider I was just trying to follow the existing pattern. This should go into a separate PR. here is an issue for this: #1110 |
9785a08 to
2309d47
Compare
stephenhillier
left a comment
There was a problem hiding this comment.
Nice! I tested the CLI and SDK (async and non-async clients), working great for me. Good catch on the missing/commented asset functions.
Co-authored-by: Steve Hillier <stephenhillier@gmail.com>
19370ca to
7c20f21
Compare
The changes focus on improving item assessment(
item-get,item-coverage), asset management(asset-get,asset-list) and making the API more consistent.item-get: new in Async client, Sync Client, CLIitem-coverage: new in Async client, Sync Client, CLIasset-get: new(un-commented) in CLIasset-list: new in CLIdocs/cli/cli-data.mddesign-docs/CLI-DATA.mdITEM_TYPE, IDconvention (few examples are out-of-date and no longer work)