feat: add item coverage and asset management in DataClient #1109
Conversation
wiki0831
force-pushed
the
wei/data-api-item-coverage
branch
from
a632f22 to
9785a08
Compare
| # @click.argument("item_id") | ||
| # @click.argument("asset_type_id") | ||
| # @pretty | ||
| # async def asset_get(ctx, item_type, item_id, asset_type_id, pretty): |
There was a problem hiding this comment.
unclear on why asset-get was commented out earlier.
asset-get and asset-list flows nicely with the new item-coverage command so i added them in.
|
looks good so far! one thing we've been trying to do w/ tests is combine the sync/async calls into a single case since the setup and assertions are the same, the only difference is in invocation... see |
thanks @ischneider I was just trying to follow the existing pattern. This should go into a separate PR. here is an issue for this: #1110 |
wiki0831
force-pushed
the
wei/data-api-item-coverage
branch
from
9785a08 to
2309d47
Compare
|
|
||
| You can also specify additional parameters: | ||
|
|
||
| * `--mode`: The mode for coverage calculation |
There was a problem hiding this comment.
| * `--mode`: The mode for coverage calculation | |
| * `--mode`: The mode for coverage calculation | |
| * `UDM2`: calculate clear coverage using a UDM2 asset [default] | |
| * `estimate`: estimate clear coverage based on preview imagery |
Let's add the options here (feel free to adjust as you see fit)
| * `--mode`: The mode for coverage calculation | ||
|
|
||
| * `--band`: The band to use for coverage calculation | ||
|
|
There was a problem hiding this comment.
| See [Data API documentation](https://docs.planet.com/develop/apis/data/items/#estimate-clear-coverage-over-an-individual-item-with-a-custom-aoi) for an overview of coverage options. | |
The changes focus on improving item assessment(
item-get,item-coverage), asset management(asset-get,asset-list) and making the API more consistent.item-get: new in Async client, Sync Client, CLIitem-coverage: new in Async client, Sync Client, CLIasset-get: new(un-commented) in CLIasset-list: new in CLIdocs/cli/cli-data.mddesign-docs/CLI-DATA.mdITEM_TYPE, IDconvention (few examples are out-of-date and no longer work)