Move v2 orders client over to async #240
Conversation
|
Functionality is implemented, fully tested. Todo: update documentation |
…om objects as well as dict
jreiberkyle
changed the title
|
For the sake of not making more noise than I already have, are there thoughts in general around typing functions and such? I'm going to stop commenting on every function for now. :) |
|
@ericrdunham 'Please remove all console functionality from models.' can you be more explicit? |
Sure thing! The "console functionality" that I'm thinking of is anything that assumes a console or GUI in the models and the first example (and maybe the only one?) is in |
|
@ericrdunham gotcha. Let's hammer this out within the context of that one comment thread. |
There was a problem hiding this comment.
@jreiberkyle I added a comment elsewhere (lost somewhere in the depths of github, maybe) but my only request is we go ahead and pull out CLI docs pending #244 - otherwise LGTM
|
great! thanks @sarasafavi , @ericrdunham and @strixcuriosus - your thoughtful reviews and understanding around such a large PR are much appreciated. |
Switch v2 orders client to async. Also adds sophisticated order details handling (definition of products, tools, notifications, and delivery into a single order detail).
Note, this is just the python library. CLI will be implemented in #244.
Closes #238
TODOs that will be addressed in the future: make all docs markdown docs #242, and convert testing/docbuilds to nox #243